Removed observable function calls from template (part 1) #3585
Conversation
… between different groups Also fixed edit ePerson not showing the group names
…te-7.6' into w2p-117573_remove-observable-function-calls_contribute-main # Conflicts: # src/app/access-control/epeople-registry/eperson-form/eperson-form.component.html # src/app/access-control/group-registry/group-form/group-form.component.ts
alexandrevryghem
added
bug
high priority
performance / caching
alexandrevryghem
force-pushed
the
w2p-117573_remove-observable-function-calls_contribute-main
branch
from
9ef1f65
to
0cb5b76
Compare
|
I'm beginning to wonder if #3584 might be caused by a similar issue. I'm not confident this PR would fix #3584, but the issue described in that ticket seems similar to the issues fixed by this PR. Regardless, this is a high priority PR for me to get back to testing. Hoping to get to it sometime this week. |
…n the profile page
|
Hi @alexandrevryghem, @tdonohue, Results for each issue:
All those are very welcome fixes with no doubt! Thanks @alexandrevryghem |
|
@tdonohue Following your comment (#3585 (comment)) on the potential impact of this PR against the #3584 issue, I have tried to reproduced the bug (on my DSpace Docker install, backend on Main branch) but was not able too. I followed the same step as on the video provided on the issue, I also clic on many different sections (list of collection, collection, item, etc.) but did not encounter the infinite loop bug. This said...more test required! |
|
@alexandrevryghem , I've merged the changes of this PR into main. The problem that is described in #3584 is not solved. I can safely reproduce the "infinite load" problem in my local dev instance. |
|
@saschaszott: That's indeed a separate issue, this PR only fixes #3393, #3257, #3571 & #3612 |
|
@alexandrevryghem , thanks! I can confirm that #3393, #3257, #3571 are fixed by this PR. |
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! Reviewed and tested this today. The code looks good to me. I tested that all 4 bugs are fixed. I also did some basic testing of the functionality of the EPerson/Group/Metadata Registry/Bitstream Registry, as those are the pages that were modified most significantly. No issues found, so this looks great to me.
Merging immediately as this has had several testers. This should be ported to 7.6.x and 8.x (to fix the same bugs there).
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3585-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3585-to-dspace-7_x
git switch --create backport-3585-to-dspace-7_x
git cherry-pick -x 70f0af66117722e4d12d2b828ee85537946e69de d3019e4006aaa72f1dd8561a8d83050e48a9cebb 680ed3bccf38732ada602a7f01487c60035067ac b55686e1870cfb5083832239b5b2dbe18160c419 c74c178533d8ffd2c4cca926896b703e10af00b8 f03ed89687e12fa849e73b336e95fb2ab2996033 59e5f71a73053f8633446a1f43965ee99e4693f6 976ac7604be2458c31f92b6af05e94df453a74ea 0cb5b76159ce41b8b15192010ff7c89ab9911d21 ded0079f24e0f6670f357e545e9ff14219aa4913 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3585-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3585-to-dspace-8_x
git switch --create backport-3585-to-dspace-8_x
git cherry-pick -x 70f0af66117722e4d12d2b828ee85537946e69de d3019e4006aaa72f1dd8561a8d83050e48a9cebb 680ed3bccf38732ada602a7f01487c60035067ac b55686e1870cfb5083832239b5b2dbe18160c419 c74c178533d8ffd2c4cca926896b703e10af00b8 f03ed89687e12fa849e73b336e95fb2ab2996033 59e5f71a73053f8633446a1f43965ee99e4693f6 976ac7604be2458c31f92b6af05e94df453a74ea 0cb5b76159ce41b8b15192010ff7c89ab9911d21 ded0079f24e0f6670f357e545e9ff14219aa4913 |
|
@alexandrevryghem : Could you manually port this to both 8.x and 7.6.x? It looks like it's too large to port automatically (it also could be that some bugs are specific to 8.x) |
References
Description
Currently, there are multiple instances where observable function calls are subscribed to directly in the template. This is considered a bad practice, as it cause a new Observable to be recreated each time Angular’s change detection is triggered. Some instances of this issue remain, but I will work on creating PRs to address them over the coming months.
Instructions for Reviewers
Guidance for how to test & review this PR:
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.